refactor(managedBy): one parser for the userActions override shape (completes #2712) by os-zhuang · Pull Request #2724 · objectstack-ai/objectui

os-zhuang · 2026-07-20T04:00:47Z

Completes the objectui#2712 de-dup and closes item #1 of the framework tracking issue objectstack-ai/framework#3343. Follows framework ADR-0103.

Problem

#2712 consolidated the managedBy bucket union + affordance set mirrors, but deliberately left the small inline userActions handlers that still parse the override shape (bare boolean vs. #2614 { enabled, visibleWhen, disabledWhen } object form) by hand. There were actually four such surfaces — three named in the issue plus RelatedList, which had its own copy of predicatesOf.

Approach — one parser in `@object-ui/core`

@object-ui/core promotes the internal normalizeOverride to the exported normalizeUserAction(v, base) — THE single parser — and adds userActionPredicates(v) for per-record CEL predicate extraction. resolveCrudAffordances now calls it too.
app-shell/utils/managedByEmptyState.ts — the writable-system create check and its local EmptyStateUserActions interface → resolveCrudAffordances({ managedBy, userActions }).create.
plugin-grid/rowCrudAffordances.ts — local isOptedOut / predicatesOf (and duplicated RowCrudUserAction / RowCrudPredicates types) fold into normalizeUserAction; the historical type names stay re-exported for import compat.
plugin-detail/RelatedList.tsx — inline predicatesOf → userActionPredicates.
plugin-form/ObjectForm.tsx — the hand-rolled managedBy !== 'platform' blanket lock + userActions unlock → the resolved affordance for the current mode (edit / create), the same resolveCrudAffordances contract the detail (isObjectInlineEditable) and grid surfaces use.

Acceptance (from #3343): no package re-parses the userActions override shape locally. ✔

Behavior

Behavior-preserving for platform / system / append-only / better-auth, with one deliberate alignment: an admin-editable config-bucket object (e.g. sys_webhook, sys_permission_set) is now editable in ObjectForm. It was previously over-locked as "non-platform", while detail/grid already treated it as editable (config resolves edit: true, and the framework declares config permits direct mutation). This is exactly the "match detail/grid exactly" fix the issue calls for.

Tests

@object-ui/core: new unit coverage for normalizeUserAction + userActionPredicates.
plugin-form: new ObjectForm.managedEdit cases pinning the aligned config edit gate and the create-mode routing (engine-owned locked vs. userActions.create unlocked).
All existing affordance / edit-gate tests stay green (core + plugin-grid + plugin-form + plugin-detail + app-shell/utils: 1767 + 226 pass locally); type-check green for all five packages; no new lint errors introduced.

🤖 Generated with Claude Code

…ompletes #2712, framework#3343) #2712 consolidated the bucket union + affordance set mirrors but left four surfaces still parsing the `userActions.{create,edit,delete}` override shape by hand. They now all route through the shared @object-ui/core policy — no package re-implements the boolean / #2614-object-form parse locally. - core: promote internal `normalizeOverride` to exported `normalizeUserAction` (the one parser) + add `userActionPredicates` for per-record predicate extraction. - app-shell/managedByEmptyState: writable-`system` create check + local `EmptyStateUserActions` → `resolveCrudAffordances({ managedBy, userActions }).create`. - plugin-grid/rowCrudAffordances: local `isOptedOut`/`predicatesOf` + duplicated types fold into `normalizeUserAction`; historical type names stay re-exported. - plugin-detail/RelatedList: inline `predicatesOf` → `userActionPredicates`. - plugin-form/ObjectForm: hand-rolled `managedBy !== 'platform'` blanket lock + userActions unlock → resolved affordance for the mode (edit/create), the same `resolveCrudAffordances` contract detail (`isObjectInlineEditable`) and grid use. Behavior-preserving for platform/system/append-only/better-auth, with one deliberate alignment: an admin-editable `config` object (sys_webhook, sys_permission_set) is now editable in ObjectForm — it was over-locked as non-`platform` while detail/grid already treated it as editable (config resolves edit:true). New unit coverage for the shared parser + the config/create-mode form gate; all existing affordance/edit-gate tests stay green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

vercel · 2026-07-20T04:00:53Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 20, 2026 4:00am

github-actions · 2026-07-20T04:04:23Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.0 KB	350 KB
Entry file	`index-Dbu7agMt.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.19KB	2.96KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.70KB	4.21KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.86KB	5.29KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.43KB	2.09KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	33.74KB	8.53KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.83KB	0.79KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.86KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	450.03KB	97.83KB
core (index.js)	1.86KB	0.63KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	120.81KB	30.10KB
fields (index.js)	210.46KB	51.53KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.22KB	4.69KB
i18n (useSafeTranslation.js)	2.87KB	1.28KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.90KB	2.15KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.31KB	13.06KB
plugin-chatbot (index.js)	179.58KB	42.81KB
plugin-dashboard (index.js)	113.58KB	28.77KB
plugin-designer (index.js)	213.43KB	42.95KB
plugin-detail (index.js)	213.08KB	51.84KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	102.82KB	24.94KB
plugin-gantt (index.js)	162.24KB	39.49KB
plugin-grid (index.js)	174.18KB	45.91KB
plugin-kanban (index.js)	47.23KB	12.88KB
plugin-list (index.js)	98.22KB	23.21KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.81KB	9.98KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.74KB	20.86KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.70KB	6.09KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.76KB	0.42KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	2.02KB	0.95KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.17KB	0.17KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (system-fields.js)	2.39KB	1.17KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added package: core plugin tests labels Jul 20, 2026

os-zhuang mentioned this pull request Jul 20, 2026

feat(managedBy): explicit engine-owned lifecycle bucket (tracks framework ADR-0103 addendum) #2739

Merged

os-zhuang merged commit 0a3710b into main Jul 20, 2026
14 checks passed

os-zhuang deleted the refactor/managedby-dedup-useractions branch July 20, 2026 07:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(managedBy): one parser for the userActions override shape (completes #2712)#2724

refactor(managedBy): one parser for the userActions override shape (completes #2712)#2724
os-zhuang merged 1 commit into
mainfrom
refactor/managedby-dedup-useractions

os-zhuang commented Jul 20, 2026

Uh oh!

vercel Bot commented Jul 20, 2026

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jul 20, 2026

Problem

Approach — one parser in @object-ui/core

Behavior

Tests

Uh oh!

vercel Bot commented Jul 20, 2026

Uh oh!

github-actions Bot commented Jul 20, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Approach — one parser in `@object-ui/core`